WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#23585 closed enhancement (fixed)

Twenty Thirteen: Theme customizer: transport => postMessage for header_textcolor

Reported by: SriniG Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: trunk
Severity: normal Keywords: has-patch
Cc:

Description

Why refresh header_textcolor when we can have live js preview?

Attachments (3)

23585.diff​ (1.4 KB) - added by SriniG 4 months ago.
23585.1.diff​ (1.9 KB) - added by SriniG 4 months ago.
23585.2.diff​ (2.4 KB) - added by SriniG 4 months ago.
Updating the 'version' parameter for wp_enqueue_script( 'twentythirteen-customizer',...)

Download all attachments as: .zip

Change History (9)

SriniG — 4 months ago

comment:1 SriniG — 4 months ago

  • Keywords has-patch added

comment:2 follow-up: lancewillett — 4 months ago

  • Milestone changed from Awaiting Review to 3.6

Good idea, want to also look at adding this to Twenty Twelve?

SriniG — 4 months ago

comment:3 SriniG — 4 months ago

  • Keywords needs-testing added

The first patch has a little problem. It works beautifully the first time, but after you set a color, save the changes and try it again, it doesn't work. Seems this is due to the !important rule in custom-header. So removed the rule, and attachment:23585.1.diff​ is the consolidated patch. Not sure if removing the !important would cause other problems.

Last edited 4 months ago by SriniG (previous) (diff)

comment:4 in reply to: ↑ 2 SriniG — 4 months ago

Replying to lancewillett:

Good idea, want to also look at adding this to Twenty Twelve?

Sure, I'm trying, but looks like it's a little complicated with Twenty Twelve.

SriniG — 4 months ago

Updating the 'version' parameter for wp_enqueue_script( 'twentythirteen-customizer',...)

comment:5 lancewillett — 4 months ago

  • Keywords needs-testing removed

Latest patch looks good, thanks!

See #23600 for Twenty Twelve version.

comment:6 lancewillett — 4 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23493:

Twenty Thirteen: instantly preview header text color changes in the Theme Customizer. Fixes #23585, props SriniG.

Note: See TracTickets for help on using tickets.