Opened 3 months ago

Closed 3 months ago

#23586 closed defect (bug) (fixed)

Twenty Twelve: Content margin missing in some cases

Reported by: obenland Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: 3.5.1
Severity: normal Keywords: has-patch commit
Cc:

Description (last modified by obenland)

When the background color is set to #fff or is not set at all, and a background image is added, the #page is missing margins to the left and right.

Attachments (2)

23586.diff​ (2.9 KB) - added by obenland 3 months ago.
23586.2.diff​ (2.4 KB) - added by lancewillett 3 months ago.

Download all attachments as: .zip

Change History (7)

obenland — 3 months ago

lancewillett — 3 months ago

comment:1   lancewillett — 3 months ago

Fix one indentation in functions.php logic. Also, I don't think you need the extra JS for background image handling.

comment:2   lancewillett — 3 months ago

OK, take back the part about the extra JS. It is needed, but still testing it out. I think there's one case it fails still.

comment:3   lancewillett — 3 months ago

  • Keywords commit added

First patch -- 23586.diff -- tests out well now, I had a cached JS file mistakenly.

comment:4   obenland — 3 months ago

  • Description modified (diff)

comment:5   lancewillett — 3 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23568:

Twenty Twelve: better handling for cases where a background color is set to white or an empty value (like first run with no theme_mods set) and a background image is enabled, which resulted previously in a broken layout. Fixes #23586, props obenland.

Note: See TracTickets for help on using tickets.