Opened 3 months ago

Closed 2 months ago

#23600 closed enhancement (fixed)

Twenty Twelve: Theme customizer: transport => postMessage for header_textcolor

Reported by: SriniG Owned by: lancewillett
Priority: normal Milestone: 3.6
Component: Bundled Theme Version: trunk
Severity: normal Keywords: needs-patch
Cc:

Description

Live js preview for the header_textcolor option in the theme customizer.

Attachments (5)

23600.diff​ (2.4 KB) - added by SriniG 3 months ago.
23600.2.patch​ (2.1 KB) - added by lancewillett 3 months ago.
A few minor fixes, also align assignments
23600.2.diff​ (752 bytes) - added by SergeyBiryukov 2 months ago.
23600.3.diff​ (1.3 KB) - added by SergeyBiryukov 2 months ago.
23600.4.diff​ (1.0 KB) - added by obenland 2 months ago.

Download all attachments as: .zip

Change History (11)

SriniG — 3 months ago

comment:1   SriniG — 3 months ago

  • Component changed from General to Bundled Theme

comment:2   lancewillett — 3 months ago

  • Milestone changed from Awaiting Review to 3.6

lancewillett — 3 months ago

A few minor fixes, also align assignments

comment:3   lancewillett — 3 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23572:

Twenty Twelve: enable live preview for Header Text Color in Theme Customizer. Change also removes an !important declaration (yay) in Custom Header CSS rules.

Props SriniG, fixes #23600.

SergeyBiryukov — 2 months ago

comment:4   SergeyBiryukov — 2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This introduced a bug with "Display Header Text" checkbox, see #23722.

SergeyBiryukov — 2 months ago

comment:5   lancewillett — 2 months ago

  • Keywords needs-patch added; has-patch removed
  • Severity changed from minor to normal

obenland — 2 months ago

comment:6   lancewillett — 2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 23711:

Twenty Twelve: fix regression introduced in r23572, allow hide/show of Header Text in Customizer. Fixes #23600.

Also remove another !important -- and there was much rejoicing.

Props SergeyBiryukov and obenland.

Note: See TracTickets for help on using tickets.