#23619 closed defect (bug) (fixed)
Twenty Thirteen: use new URL extraction function for link post format
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | contact@…, philip@… |
Description
Replace twentythirteen_get_first_url() URL grabber function in Twenty Thirteen with the new core version.
See #23570 for the suggested new function(s).
Note: Twenty Thirteen does not need back compat with pre 3.6 versions
Attachments (1)
Change History (12)
comment:1
lancewillett — 3 months ago
- Keywords twentythirteen added
comment:2
lancewillett — 3 months ago
- Keywords twentythirteen removed
Frank Klein — 3 months ago
comment:3
Frank Klein — 3 months ago
- Cc contact@… added
- Keywords has-patch added; needs-patch removed
- Cc philip@… added
comment:5
lancewillett — 2 months ago
In 23786:
comment:6
lancewillett — 2 months ago
In 23787:
comment:7
lancewillett — 2 months ago
- Keywords needs-testing added; has-patch removed
Lets keep this ticket open to test all the scenarios listed by Frank Klein above.
Looks good. I wonder if the function name is still the best since the function no longer looks for the first url. Couldn't come up with anything better than twentythirteen_get_link_url(), though.
comment:9
lancewillett — 2 months ago
- Keywords needs-testing removed
twentythirteen_get_link_url() is a better name, thanks.
Also noting, we should not allow this function to be pluggable, per same idea of #23674.
comment:10
lancewillett — 2 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23795:
comment:11
lancewillett — 8 weeks ago
In 23803:

Here are the different scenarios with the output they produce: