Opened 3 months ago
Closed 3 months ago
#23631 closed defect (bug) (fixed)
Twenty Thirteen: Multisite register screen content is too wide
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Bundled Theme | Version: | trunk |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
The Register screen for Multisite (wp-signup.php) is too wide; it has no defining widths for content.
Attachments (5)
Change History (12)
comment:1
lancewillett — 3 months ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.6
DrewAPicture — 3 months ago
DrewAPicture — 3 months ago
comment:2
DrewAPicture — 3 months ago
- Keywords has-patch added; needs-patch removed
23631.diff adds a max-width of 1040px for .mu_register. Feel free to move it wherever seems appropriate.
Viewable in mu_signup_max_width.png
I went a little heavier here with 23631.2.diff.
- Changed some markup in wp-signup.php, allowing better targeting of helper text (I don't believe it could affect anything in the wild)
- Removed some aggressive form field styling in wp-signup.php, which allows more consistent styling by inheritance (helps Twenty Twelve a bit too)
- Went with a narrower 604px single-column width for the form's container
- Some additional Twenty Thirteen specific styling
If there's interest in this direction, I'm assuming the signup.php changes should be done in a new separate ticket?..
comment:4
lancewillett — 3 months ago
Yes, please only patch Twenty Thirteen here. (The signup.php stuff in a different ticket.)
23631.3.diff styles Multisite forms without relying on wp-signup.php markup changes.
comment:6
lancewillett — 3 months ago
Good patch, Kirk -- only change I made was swap lines 2446 and 2447, for alphabetical properties within the block.
comment:7
lancewillett — 3 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23513:

With max-width 1040px