Tweaks to menu management box

[lessbloat]

In office hours on Monday we discussed making some changes to the menu management box currently at the top of the menus screen (when you have more than one menu).

We are going to show the box at all times with the following:

Zero menus: Edit your menu below, or start with a blank menu
One menu: Edit your menu below, or add a new menu
Multiple menus: Select a menu to edit [DROPDOWN] [SELECT] or add a new menu

23641.2.diff​ removes the 'Add New' button next to the screen icon and adds differing text based on $menu_count.

Zero menus:

One menu:

Two+ menus:

I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:

Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.

Replying to lessbloat:

I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:

Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.

Looks pretty good. For zero menus, what about this:

 Edit your menu below, or create a new blank menu

instead of this:

 Edit your menu below, or create a blank new menu

Replying to DrewAPicture:

For zero menus, what about this:

 Edit your menu below, or create a new blank menu

instead of this:

 Edit your menu below, or create a blank new menu

Let's just go with: Edit your menu below, or create a new menu.

What do you say?

Consolidate two new strings to one: 'create a new menu'

Talked with @lessbloat and we decided to go with one new string all around for the second part of the 'sentence', handled in 23641.4.diff​

Zero & one menus:

Edit your menu below, or create a new menu.

Multiple menus:

Select a menu to edit [dropdown] [Select] or create a new menu.

23641.4.diff​ looks solid to me.

I don't think you can break up sentences or it messes with translation.

<?php _e( 'Edit your menu below, or' ); ?> <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ); ?>"><?php esc_html_e( 'create a new menu' ); ?></a>

Should be something like this:

<?php
printf( __( 'Edit your menu below, or <a href="%s">create a new menu</a>' ), esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ) );
?>

We may need to have one of the translators look at this or at least someone with more translation chops than me.

fixes the translation strings

23641.5.diff​ looks good to me in terms of the strings.

Minor corrections in 23641.6.diff​:

• Added an ending dot to the string in line 465 for consistency with the one in line 499.
• Added a colon to the string in line 470.

In 23622:

Tweak the Nav Menu UX, especially around menu creation.

props lessbloat, DrewAPicture, jkudish. fixes #23641

In 23623:

RTL for Nav Menu tweaks. see #23641. fixes #23645. props DrewAPicture.

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

Replying to markjaquith:

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

Maybe @lessbloat could add this to the next round of user tests. Worth looking at.

I also reopened #23645 pending other RTL fixes.

Replying to markjaquith:

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

I'm all for it. Done in 23641.7.diff.

"Add New" string should have context?

'Add New' w/ context

Replying to pavelevap:

"Add New" string should have context?

Good catch. Added in 23641.8.diff​

In 23641:

Add back "Add New" next to h2 on Nav Menus screen.

props DrewAPicture. see #23641

An new issues with this should be in a new ticket.

In 23748:

RTL for Nav Menu tweaks. see #23641. see #23645. props DrewAPicture

In 23808:

RTL for Nav Menu tweaks. see #23641. see #23645. props lessbloat