Opened 3 months ago

Closed 2 months ago

#23645 closed defect (bug) (fixed)

RTL fixes for Nav Menu UI refresh

Reported by: DrewAPicture Owned by: markjaquith
Priority: normal Milestone: 3.6
Component: RTL Version: trunk
Severity: normal Keywords: 3.6-menus has-patch
Cc: maorhaz@…

Description

With the substantial UI changes we've made to menu management, we'll need to adjust for RTL.

3.6-Menus tracking ticket: #23607

Attachments (4)

23645.diff​ (648 bytes) - added by DrewAPicture 3 months ago.
Pending changes in #23641
23645.2.diff​ (548 bytes) - added by DrewAPicture 2 months ago.
Remove | Cancel float
23645.3.diff​ (833 bytes) - added by DrewAPicture 2 months ago.
23645.4.diff​ (1.6 KB) - added by lessbloat 2 months ago.

Download all attachments as: .zip

Change History (16)

DrewAPicture — 3 months ago

Pending changes in #23641

comment:1   DrewAPicture — 3 months ago

  • Component changed from Menus to RTL
  • Keywords has-patch added; needs-patch removed

23645.diff​ adds RTL styles for changes pending in #23641

comment:2   markjaquith — 3 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23623:

RTL for Nav Menu tweaks. see #23641. fixes #23645. props DrewAPicture.

comment:3   DrewAPicture — 3 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

There's bound to be other RTL fixes. Let's leave this open for now.

comment:4   maor — 3 months ago

  • Cc maorhaz@… added

DrewAPicture — 2 months ago

Remove | Cancel float

comment:5   DrewAPicture — 2 months ago

  • Keywords has-patch added; needs-patch removed

comment:6 follow-up: ↓ 7   SergeyBiryukov — 2 months ago

Let's also fix indentation (tabs vs. spaces) in [23623].

DrewAPicture — 2 months ago

comment:7 in reply to: ↑ 6   DrewAPicture — 2 months ago

Replying to SergeyBiryukov:

Let's also fix indentation (tabs vs. spaces) in [23623].

That's weird. Not sure why that one had spaces. Done in 23645.3.diff

comment:8   DrewAPicture — 2 months ago

I think 23645.3.diff​ is ready to go in. We may have a few more fixes once we wrap up #23770.

comment:9   ryan — 2 months ago

In 23748:

RTL for Nav Menu tweaks. see #23641. see #23645. props DrewAPicture

lessbloat — 2 months ago

comment:10   lessbloat — 2 months ago

23645.4.diff adds two small RTL tweaks:

1) "Sub item" label
2) Accessibility "Move" links

Last edited 2 months ago by lessbloat (previous) (diff)

comment:11   markjaquith — 2 months ago

In 23808:

RTL for Nav Menu tweaks. see #23641. see #23645. props lessbloat

comment:12   DrewAPicture — 2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

I think we can close this now.

Note: See TracTickets for help on using tickets.