Opened 3 months ago

Last modified 3 months ago

#23724 new enhancement

Pass $post into 'protected_title_format' and 'private_title_format' filters

Reported by: johnjamesjacoby Owned by:
Priority: low Milestone: Awaiting Review
Component: Template Version: 3.5
Severity: minor Keywords: has-patch
Cc:

Description

Currently it's only possible to change these prefixes globally.

Being able to change these prefixes based on specific $post data would be helpful for narrowing down the scope, say to specific custom post types.

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

Attachments (2)

23724.patch (909 bytes) - added by johnjamesjacoby 3 months ago.
23724.2.patch (786 bytes) - added by johnjamesjacoby 3 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 follow-up: ↓ 2   SergeyBiryukov3 months ago

  • Version changed from trunk to 3.5

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

Passing $post to protected_title_format and private_title_format makes sense to me.

comment:2 in reply to: ↑ 1   johnjamesjacoby3 months ago

Replying to SergeyBiryukov:

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

I hadn't considered these. Agree adding anything to 'the_title' should be consistent. Will repatch with that bit. Thanks for the heads up there.

Last edited 3 months ago by johnjamesjacoby (previous) (diff)
Note: See TracTickets for help on using tickets.