WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#23726 closed enhancement (fixed)

Show Audio and Video previews on Edit Attachment screen

Reported by: wonderboymusic Owned by: markjaquith
Priority: normal Milestone: 3.6
Component: Media Version:
Severity: normal Keywords: has-patch
Cc:

Description

edit-form-advanced.php handles media, but only images. With audio / video support in #23282, it is now possible to display audio and video previews in the admin, so let's do that

Attachments (2)

23726.diff​ (2.1 KB) - added by wonderboymusic 3 months ago.
23726.2.diff​ (2.2 KB) - added by wonderboymusic 3 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 wonderboymusic — 3 months ago

  • Component changed from Post Formats to Media

wonderboymusic — 3 months ago

comment:2 wonderboymusic — 3 months ago

  • Keywords has-patch added

comment:3 markjaquith — 3 months ago

Is there some CSS missing here? Looks funky:

http://f.cl.ly/items/0G2x0W1r0R1I2x26452O/Screen%20Shot%202013-03-20%20at%202.42.37%20AM.png

comment:4 wonderboymusic — 3 months ago

that's because #23673 is required - audio and video don't have metadata without it, which means width and height can't be calculated so the shortcode explodes. #23282 and #23673 are the baseline functionality

wonderboymusic — 3 months ago

comment:5 markjaquith — 3 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23768:

Show a playable audio/video preview on the Edit Attachment screen.

props wonderboymusic. fixes #23726

Note: See TracTickets for help on using tickets.