#23732 closed defect (bug) (fixed)
Twenty Thirteen: improve header area padding to ensure stable layout at any size screen
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Bundled Theme | Version: | trunk |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
Viewing Twenty Thirteen on Google TV, there is no side padding on the main title or navigation when zoomed in (which is default). The added padding in the media query doesn't apply. If padding was added to the base styles instead, it would adjust nicely.
Attachments (4)
Change History (14)
- Milestone changed from Awaiting Review to 3.6
- Type changed from enhancement to defect (bug)
I like the patch, it has the added bonus of never coming in the situation weher we have not enough padding, like right before the 1069px media query kicks in.
jvisick77, would you mind refreshing the patch? The IE8 style should be moved into /css/ie.css and I think we can also remove the .site-header hgroup selector around line 2700. Could you also make sure to create the patch from WordPress' root directory? Thank you! :)
Yeah, I like not relying on media queries for padding if possible. I adjusted alignment for IE7 too.
comment:4
lancewillett — 2 months ago
- Priority changed from normal to low
comment:5
lancewillett — 2 months ago
- Priority changed from low to normal
- Summary changed from Twenty Thirteen: no side padding on main title and nav when viewed on google tv to Twenty Thirteen: improve header area padding to ensure stable layout at any size screen
comment:6
lancewillett — 2 months ago
Patch looks good. I tested in a bunch of screen sizes and browsers.
comment:7
lancewillett — 2 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23678:
@lancewillet I'm not sure if this was intentional for other reasons, but the following adjustment to the header width in ie.css was dropped in the update. Without it the alignment is off for ie8/7.
.site-header hgroup {
max-width: 1040px;
}
comment:9
in reply to:
↑ 8
lancewillett — 2 months ago
Replying to jvisick77:
I'm not sure if this was intentional for other reasons
Nope, wasn't on purpose. Probably my mistake or patch didn't apply cleanly for some reason. I'll fix it.
comment:10
lancewillett — 2 months ago
In 23688:

Twenty Thirteen on Google TV