Opened 2 months ago

Closed 2 months ago

#23743 closed defect (bug) (fixed)

TinyMCE overwrites text edits when wpautop is false

Reported by: WraithKenny Owned by: azaozz
Priority: normal Milestone: 3.6
Component: TinyMCE Version: 3.3
Severity: major Keywords: has-patch
Cc: Ken@…

Description

The logic at http://core.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js#L219 is inverted.

Patch fixes.

Attachments (2)

23743.diff​ (1.2 KB) - added by WraithKenny 2 months ago.
23743-nocomments.patch​ (832 bytes) - added by WraithKenny 2 months ago.

Download all attachments as: .zip

Change History (9)

WraithKenny — 2 months ago

comment:1   WraithKenny — 2 months ago

The possible permutations are:

  1. 'wpautop' = false, ed.hidden()
  2. 'wpautop' = true, ed.hidden()
  3. 'wpautop' = false, ! ed.hidden()
  4. 'wpautop' = true, ! ed.hidden()

Case 1. is the problem, wherein (without the patch) ed.onSaveContent will overwrite the text edits with the old content stored in the Visual editor. The patch only changes the behavior of Case 1.

comment:2   WraithKenny — 2 months ago

  • Version set to 2.9

comment:3   WraithKenny — 2 months ago

related to #17144 version should be 3.3, sorry.

comment:4   SergeyBiryukov — 2 months ago

  • Component changed from Editor to TinyMCE
  • Milestone changed from Awaiting Review to 3.6
  • Version changed from 2.9 to 3.3

comment:5   SergeyBiryukov — 2 months ago

  • Owner set to azaozz
  • Status changed from new to reviewing

WraithKenny — 2 months ago

comment:6   WraithKenny — 2 months ago

  • Cc Ken@… added

comment:7   azaozz — 2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 23745:

Editor: preserve the textarea content when saving, wpautop is not used and TinyMCE is hidden. Props WraithKenny, fixes #23743

Note: See TracTickets for help on using tickets.