Opened 3 months ago
Closed 3 months ago
#23774 closed defect (bug) (fixed)
Twenty Ten/Eleven: Use a filter to modify the output of wp_title()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
This will help to clean up header.php as well as make the first two Twenty themes more compatible with the WPTRT guidelines:
Themes are required to modify output via filter (wp_title/body_class/post_class)
See twentytwelve_wp_title() in Twenty Twelve for example code.
Attachments (1)
Change History (6)
comment:1
lancewillett
— 3 months ago
- Milestone changed from Awaiting Review to 3.6
comment:2
lancewillett
— 3 months ago
comment:3
lancewillett
— 3 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23719:
comment:4
lancewillett
— 3 months ago
- Keywords has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
Bad news bears. :(
This change isn't backward compatible with child themes. If a child theme creates its own header.php template file, the title can be duplicated or worse.
We'll need to revert.
Twenty Twelve and onward should be fine since they shipped with the filter from the beginning.
comment:5
lancewillett
— 3 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In 23778:
In 23718: