id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
23775	WP_Image_Editor Flip Method $horz and $vert arguments are backwards	alconebay	ryan	"The WP_Image_Editor class shows:

{{{
/**
 * @param boolean $horz Horizontal Flip
 * @param boolean $vert Vertical Flip
 */
abstract public function flip( $horz, $vert );
}}}

But changing the first argument to true flips the image vertically and the second argument, when true, flips the image horizontally.
Both imagemagick and GD are affected.

A fix for class-wp-image-editor-imagick.php would be reversing lines 366 and 369 (flopImage for $horz and flipImage for $vert)

A fix for class-wp-image-editor-gd.php would be reversing $horz and $vert on lines 292-295 like this (fixed):

{{{
$sx = $horz ? ($w - 1) : 0;
$sy = $vert ? ($h - 1) : 0;
$sw = $horz ? -$w : $w;
$sh = $vert ? -$h : $h;
}}}

I've verified these fixes."	defect (bug)	closed	normal	3.6	Media	3.5.1	minor	fixed	has-patch