Opened 2 months ago
Closed 2 months ago
#23799 closed defect (bug) (fixed)
Twenty Thirteen: Untranslatable string in image.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Bundled Theme | Version: | trunk |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
The "View full X × Y resolution" string in image.php in Twenty Thirteen is untranslatable.
The attached patch fixes it.
Attachments (6)
Change History (13)
comment:1
DrewAPicture — 2 months ago
- Milestone changed from Awaiting Review to 3.6
DrewAPicture — 2 months ago
comment:2
DrewAPicture — 2 months ago
Looks like I accidentally flipped the order in the printf in 23799.2.patch. The URL should be first, title second, anchor third. I'll fix it in a little while.
DrewAPicture — 2 months ago
comment:3
lancewillett — 2 months ago
I think the "view full resolution" should leave out the dimensions entirely, just simplify the text a bit.
lancewillett — 2 months ago
comment:4
lancewillett — 2 months ago
Was thinking more like .5 patch -- the width and height can be output but don't need to be translated.
lancewillett — 2 months ago
comment:5
lancewillett — 2 months ago
.6 is even simpler.
What if the order is changed in some languages? What about a combination of .3 and .6? So .3 is changed to have the wording of .6
comment:7
lancewillett — 2 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In 23758:
Note: See
TracTickets for help on using
tickets.
23799.2.patch takes a more structured approach, so we can avoid having all that extra markup in the string. Also converts the height and width specifiers to decimal.