Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2570 closed defect (bug) (fixed)

Comments feed problem in current 2.1-alpha1 (revision 3643)

Reported by: tinyau Owned by: davidhouse
Priority: normal Milestone: 2.1
Component: General Version: 2.1
Severity: major Keywords: bg|has-patch bg|tested bg|commit
Cc:

Description

I found there are 2 problems of comments feed in the current revision 3643.

  1. "All Comments" feed generated the same content as Posts feed.
  2. Comments feed of individual posts cannnot show the comments of the posts.

Attachments (2)

2570.diff​ (422 bytes) - added by davidhouse 7 years ago.
2570.2.diff​ (2.3 KB) - added by davidhouse 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1   davidhouse — 7 years ago

  • Owner changed from anonymous to davidhouse
  • Status changed from new to assigned

davidhouse — 7 years ago

comment:2   davidhouse — 7 years ago

  • Keywords bg|has-patch added

Try that.

comment:3   davidhouse — 7 years ago

Err, never mind, that patch is completely broken. Working on a second.

comment:4   davidhouse — 7 years ago

Try this second one.

davidhouse — 7 years ago

comment:5   skippy — 7 years ago

  • Keywords bg|tested bg|commit added

second patch fixes the problem described in the ticket.

comment:6   ryan — 7 years ago

We also need to add $id and $comment to the list of globals in load_template() for back compat.

comment:7   ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3644]) Comment feed fixes from David House. fixes #2570

comment:8   davidhouse — 7 years ago

Perhaps we could just do the old trick of extract($GLOBALS); to give anything loaded by load_template() global scope.

comment:9   ryan — 7 years ago

Sounds good.

Note: See TracTickets for help on using tickets.