Opened 10 years ago
Closed 10 years ago
#25959 closed defect (bug) (fixed)
Appearance Themes: base64 encode a default theme screenshot for when a theme lacks one
Reported by: | matveb | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Customize | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
Display a fallback image when a theme lacks a screenshot instead of returning false.
(The image provided can also be reduced to a simple pattern and use background-repeat.)
Attachments (4)
Change History (16)
#2
@
10 years ago
- Keywords has-patch added
Looks good! Moved the second check a bit so the multiple screenshot part is kept inside the first conditional.
#3
@
10 years ago
Why are we base64'ing an image in the CSS?
What benefit does it have other than adding an extra image to core to handle it instead?
#4
@
10 years ago
Not much really. It was an image before. Nacin mentioned it would be interesting to try encoding it instead — avoid a request for what is a very simple image pattern.
#10
@
10 years ago
I had left this open specifically for feedback for lack-of-screenshot placeholder, so re-open if someone thinks the placeholder could be better or have an alternative.
Here's the encoded image: https://cloudup.com/cQtjDjD3AlN