Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25966 closed enhancement (fixed)

Appearance Themes: move theme.css to wp-admin.css

Reported by: matveb's profile matveb Owned by: ocean90's profile ocean90
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: ui Cc:

Description

CSS needs to be properly namespaced to avoid possible conflicts: #themes .theme, etc. Then merged back to the Themes section in wp-admin.css.

Remove the overwrites to add-new-h2 by adding margins to surrounding elements.

Attachments (4)

25966.patch (41.1 KB) - added by ocean90 10 years ago.
25966.2.patch (15.9 KB) - added by ocean90 10 years ago.
25966.3.patch (7.9 KB) - added by ocean90 10 years ago.
25966.4.patch (33.4 KB) - added by ocean90 10 years ago.
Merge

Download all attachments as: .zip

Change History (16)

#1 @SergeyBiryukov
10 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

#2 @matveb
10 years ago

r26291 covers the prefixing and general CSS cleanup.

@ocean90
10 years ago

#3 @ocean90
10 years ago

25966.patch is a first step.

@ocean90
10 years ago

#4 @ocean90
10 years ago

In 26482:

Themes: Prepare theme.css for a merge with wp-admin.css.

  • Let the code breathe.
  • Add necessary vendor prefixes.
  • Remove .current-label:before since it was hidden.

see #25966.

@ocean90
10 years ago

#5 @ocean90
10 years ago

In 26483:

Themes: Prepare wp-admin.css for a merge with theme.css.

  • Remove styles for #current-theme and .theme-options. Markup removed in [26141].
  • Move "Tabbed Admin Screen Interface" section out of "Themes" section. See [26466].

see #25966.

@ocean90
10 years ago

Merge

#6 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 26484:

Themes: Merge theme.css into wp-admin.css. fixes #25966.

#7 follow-up: @dd32
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

There's quite a few classes in there that are quite generic and need prefixing. .theme could be .theme-browser .theme for example.

I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed..

re-opening for class prefixing.

#8 in reply to: ↑ 7 @SergeyBiryukov
10 years ago

Replying to dd32:

I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed..

I guess the point of #18314 was to prevent the concatenated files from being downloaded each time on different screens, due to different enqueued files on each screen. However, looks like theme.css was enqueued globally in the admin before [26484], so there wouldn't be a difference in this case.

So, the merge isn't necessary, but I guess it's still nice to have one less request for non-concatenated files.

#9 @dd32
10 years ago

There's probably a middle ground, including merging some files on build, but that's better suited to a new ticket. Merging this file in was the right thing to do for now.

#10 @dd32
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26495:

Prefix the new Theme classes. Fixes #25966

#11 @ocean90
10 years ago

I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed.

Since we haven't such a build process yet I have merged them. With regards to #22862 we also shouldn't merge CSS files, we should split it up into Sass partials. But that's another topic.

Thanks for the prefix thing. Was on my list, but forget to do it.

#12 @dd32
10 years ago

In 26551:

Themes: Update the CSS definitions in the SCSS files to be as specific as the base CSS rules. See #25948, #25966

Note: See TracTickets for help on using tickets.