#25966 closed enhancement (fixed)
Appearance Themes: move theme.css to wp-admin.css
Reported by: | matveb | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | Customize | Keywords: | |
Focuses: | ui | Cc: |
Description
CSS needs to be properly namespaced to avoid possible conflicts: #themes .theme
, etc. Then merged back to the Themes section in wp-admin.css.
Remove the overwrites to add-new-h2
by adding margins to surrounding elements.
Attachments (4)
Change History (16)
#3
@
10 years ago
25966.patch is a first step.
#6
@
10 years ago
- Owner set to ocean90
- Resolution set to fixed
- Status changed from new to closed
In 26484:
#7
follow-up:
↓ 8
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
There's quite a few classes in there that are quite generic and need prefixing. .theme
could be .theme-browser .theme
for example.
I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed..
re-opening for class prefixing.
#8
in reply to:
↑ 7
@
10 years ago
Replying to dd32:
I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed..
I guess the point of #18314 was to prevent the concatenated files from being downloaded each time on different screens, due to different enqueued files on each screen. However, looks like theme.css
was enqueued globally in the admin before [26484], so there wouldn't be a difference in this case.
So, the merge isn't necessary, but I guess it's still nice to have one less request for non-concatenated files.
#9
@
10 years ago
There's probably a middle ground, including merging some files on build, but that's better suited to a new ticket. Merging this file in was the right thing to do for now.
#11
@
10 years ago
I'll also mention it.. I don't think we really needed to merge these stylesheets, I know in the past we've merged them, but now that we have script concatenation, it's not entirely needed.
Since we haven't such a build process yet I have merged them. With regards to #22862 we also shouldn't merge CSS files, we should split it up into Sass partials. But that's another topic.
Thanks for the prefix thing. Was on my list, but forget to do it.
r26291 covers the prefixing and general CSS cleanup.