Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25983 closed defect (bug) (fixed)

Appearance Themes: #appearance needs to have a computed height

Reported by: matveb's profile matveb Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

Since the content of #themes is all floated, #appearance ends up with no height. That throws off the scroll threshold check as it relies on the element's height. (Using overflow hidden causes other layout issues, so should be avoided.)

Attachments (1)

25983.diff (422 bytes) - added by matveb 10 years ago.

Download all attachments as: .zip

Change History (7)

@matveb
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

#2 @matveb
10 years ago

Helen suggested a helper class to deal with the clear.

#3 @matveb
10 years ago

Can we commit this one and in any case open a new ticket for dealing with a cleafix class? It's currently breaking the lazy-rendering of themes.

#4 @helen
10 years ago

I tried to get to this in my commit sprint last night, but ran out of steam. It's second on my next round, either later today or tomorrow at some point (today is a holiday in the US), after merging the theme CSS into the main admin styles. There are already some clearfixes in admin CSS - need to combine them.

#5 @dd32
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Didn't recognise this ticket, but fixed it via [26468]

Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).

#6 @helen
10 years ago

Leaving this alone at this point, but opened #26396 for the clearfix thing.

Note: See TracTickets for help on using tickets.