Ticket #2761 (closed defect (bug): fixed)
AYS Dialog adds slashes to quotes
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Administration | Version: | 2.0.2 |
| Severity: | major | Keywords: | has-patch 2nd-opinion |
| Cc: | gunnar@… |
Description
Post forms that go through the AYS dialog get an extra round of slashes. For instance, editing a comment turns
I'm going home.
Into:
I\'m going home
This is for version 2.0.3
Attachments
-
ays_use_textarea.diff
(966 bytes) -
added by markjaquith 6 years ago.
- Patch for 2.0.3 (branches/2.0)
-
strip_ays_post.diff
(557 bytes) -
added by ryan 6 years ago.
Change History
markjaquith — 6 years ago
-
attachment
ays_use_textarea.diff
added
comment:1
markjaquith — 6 years ago
- Keywords has-patch 2nd-opinion added
- Owner changed from anonymous to markjaquith
- Status changed from new to assigned
Patch changes the hidden inputs to hidden textareas. That way, we don't need to escape slashes.
The AYS should be designed to work in all manner of strange browsers (mobile, etc.). Can we depend on everything to deal with the CSS?
I don't understand why can't we just stripslashes the hidden field value.
This isn't a problem in trunk, but I don't see the difference. Do you?
- Status changed from assigned to closed
- Resolution set to fixed
- Resolution set to fixed
comment:7
markjaquith — 6 years ago
Just tested Ryan's patch, and it works.
I tested by editing /wp-admin/post.php and purposely mismatching the nonce keys.
And mdawaffe, yeah, you're right. I was really tired when I wrote that. Single quotes are already converted to HTML entities, so there's no problem sticking it in a hidden input.
How do us plebs apply this patch? Could someone provide an updated version of the file for 2.0.3?
comment:9
markjaquith — 6 years ago
The plebs should just use this plugin that I made:
Patch for 2.0.3 (branches/2.0)