WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2806 closed defect (bug) (fixed)

Incorrect nonce check

Reported by: westi Owned by: westi
Priority: normal Milestone:
Component: Security Version: 2.0.2
Severity: normal Keywords: bg|has-patch
Cc:

Description

I've done some greping and analysis on the calls to wp_nonce_url, wp_nonce_field and check_admin_referer in branches/2.0 and found an incorrect nonce check.

When I get the time I'll do this for trunk too :-)

Attachments (2)

2806.diff​ (461 bytes) - added by westi 7 years ago.
Patch to fix the nonce check for delete-bookmark
delete_bookmark_no_js_fix.diff​ (512 bytes) - added by markjaquith 7 years ago.
Fix for deleting bookmarks with JS off

Download all attachments as: .zip

Change History (6)

westi — 7 years ago

Patch to fix the nonce check for delete-bookmark

comment:1 westi — 7 years ago

  • Component changed from Administration to Security
  • Keywords bg|has-patch added
  • Owner changed from anonymous to westi
  • Status changed from new to assigned

comment:2 markjaquith — 7 years ago

Doesn't fix the issue. There's an action mismatch. It sends "delete" but checks for "Delete"

Note that this is all with JavaScript off... the regular AJAX deletion works fine. My patch fixes it. I'll also be updating my WordPress 2.0.3 tuneup plugin to fix this.

markjaquith — 7 years ago

Fix for deleting bookmarks with JS off

comment:3 ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3858]) Delete bookmark nonce fix from westi and markjaquith. fixes #2806

comment:4 anonymous — 7 years ago

  • Milestone 2.0.4 deleted

Milestone 2.0.4 deleted

Note: See TracTickets for help on using tickets.