Opened 7 years ago

Closed 7 years ago

#2969 closed defect (bug) (fixed)

Some Admin AJAX tweaks

Reported by: mdawaffe Owned by: mdawaffe
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: ajax javascript listman has-patch needs-testing
Cc:

Description

Both a defect and an enhancement.

Attached:

  1. Remove wp_clean_ajax_input() from admin-ajax.php. I can't remember why it's there. It may have been necessary at one point, but now it just urldecodes strings that are already udecoded. To test, try adding the category "no amp here: %26" via ajax cat. Pre-patch, you'll see: "no amp here: &". Post-patch you'll see "no amp here: %26".
  2. Allow plugins to use admin-ajax.php by firing 'wp_ajax_$action' if there's no hardcoded case.
  3. Use full path for AJAX response handler to avoid nastiness.
  4. Allow plugins to use listMan library with their own AJAX response handler.
  5. Make listMan object a little more usable to plugin JS.
  6. Step toward getting rid of nasty eval()s.

Attachments (1)

2969.diff (6.9 KB) - added by mdawaffe 7 years ago.
tweaks to list-manipulation-js.php and admin-ajax.php

Download all attachments as: .zip

Change History (4)

tweaks to list-manipulation-js.php and admin-ajax.php

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

Oh - forgot: the changeset number for list-manipulation-js.php in script-loader.php should be updated when this goes in.

comment:3   ryan7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4042]) Admin AJAX tweaks from mdawaffe. fixes #2969

Note: See TracTickets for help on using tickets.