warning returned in xmlrpc.php on pingback

[_ck_]

I am getting the following warning while doing a pingback to a test blog using 2.1a2 (however I don't believe the code in question has changed since 2.0 gold).

1. Yes it appears twice in a row.
2. I am using the pingback class from pear so I am assuming it's sending properly formed data.

<b>Warning</b>:  Invalid argument supplied for foreach() 
in <b>/home/example/public_html/news/xmlrpc.php</b> on line <b>160</b><br />
<br />
<b>Warning</b>:  Invalid argument supplied for foreach() 
in <b>/home/example/public_html/news/xmlrpc.php<

The code in question is here:

	function escape(&$array) {
		global $wpdb;

		foreach ($array as $k => $v) {
			if (is_array($v)) {
				$this->escape($array[$k]);
			} else if (is_object($v)) {
				//skip
			} else {
				$array[$k] = $wpdb->escape($v);
			}
		}
	}

I don't think the function is wrong. I think that it's one of the calls the function.

My amateur skills tell me that php doesn't like "$array" which may be passed something other than an array? Should there be a test before the loop starts? ie. is_array($array) ?

It's beyond my ability to trace what is calling it and when so I hope someone can make it respond more gracefully. Technically no human should see a pingback session error/warning response but it bothers me somewhat.

Should be fixed now. We were passing scalars instead of arrays in a few places.