Opened 7 years ago
Closed 7 years ago
#3051 closed enhancement (fixed)
QuickTags now work in Safari browser
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 2.0.6 |
| Component: | Administration | Version: | 2.0.5 |
| Severity: | trivial | Keywords: | safari quicktags maint-candidate |
| Cc: |
Description
The Safari browser has not behaved as expected when the QuickTags are used. A post at http://www.alexking.org/blog/2006/08/15/safari-cursor-aware/ made me look into the fact that they may now work. I've tested and it now works as expected meaning the disabling code can be removed from admin-functions.
Index: admin-functions.php
===================================================================
--- admin-functions.php (revision 4106)
+++ admin-functions.php (working copy)
@@ -1228,8 +1228,6 @@
}
function the_quicktags() {
- // Browser detection sucks, but until Safari supports the JS needed for this to work people just assume it's a bug in WP
- if (!strstr($_SERVER['HTTP_USER_AGENT'], 'Safari')) {
echo '
<div id="quicktags">
';
@@ -1237,7 +1235,7 @@
echo ' <script type="text/javascript">if ( typeof tinyMCE == "undefined" || tinyMCE.configs.length < 1 ) edToolbar();</script>
</div>
';
- } else echo '
+ echo '
<script type="text/javascript">
function edInsertContent(myField, myValue) {
//IE support
Attachments (1)
Change History (6)
comment:2
MattyRob
— 7 years ago
- Milestone changed from 2.1 to 2.0.5
- Resolution fixed deleted
- Status changed from closed to reopened
Can we get this into 2.0.5?
comment:3
foolswisdom
— 7 years ago
- Keywords maint-candidate added
- Milestone changed from 2.0.5 to 2.1
- Resolution set to fixed
- Status changed from reopened to closed
Sorry, too late for 2.0.5
Closing FIXED for trunk.
comment:4
mattyrob
— 7 years ago
- Milestone changed from 2.1 to 2.0.6
- Resolution fixed deleted
- Status changed from closed to reopened
- Version changed from 2.0.4 to 2.0.5
I know I keep asking (God loves a tryer!) - as this missed 2.0.5 but is fixed in [4164] for the trunk.
So, can we get this into 2.0.6 (or 2.0.7)
comment:5
markjaquith
— 7 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Ticket 3051 diff patch