Ticket #3152 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

WP_User->ID, not WP_User->id

Reported by: alexkingorg Owned by: anonymous
Priority: normal Milestone: 2.1
Component: General Version: 2.1
Severity: normal Keywords: has-patch
Cc:

Description

Fixed several references to WP_User->ID, the id is a lowercase var in this class.

Attachments

patch.diff Download (853 bytes) - added by alexkingorg 5 years ago.
patch attached
3152.diff Download (4.9 KB) - added by Nazgul 5 years ago.

Change History

alexkingorg — 5 years ago

patch attached

comment:1   ryan — 5 years ago

ID is set when we pull the users table data into the WP_User class. I'd like to stick with uppercase ID since it is more widely used due to it being in the table. How about adding var $ID = 0 to the WP_User class and putting a comment next to $id noting that it is deprecated?

comment:2   foolswisdom — 5 years ago

  • Milestone set to 2.1

Nazgul — 5 years ago

comment:3   Nazgul — 5 years ago

  • Keywords has-patch added
  • Summary changed from WP_User->id, not WP_User->ID to WP_User->ID, not WP_User->id

Created a patch, based on Ryan's suggestion.

comment:4   ryan — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [4504]) ID instead of id. Props Nazgul. fixes #3152

comment:5   ryan — 5 years ago

(In [4505]) ID instead of id. Props Nazgul. fixes #3152

Note: See TracTickets for help on using tickets.