Opened 7 years ago

Closed 6 years ago

#3177 closed defect (bug) (fixed)

"quoted strings" should work in the search box

Reported by: ringmaster Owned by: ringmaster
Priority: normal Milestone: 2.1
Component: Administration Version: 2.0
Severity: normal Keywords: search quotes has-patch
Cc:

Description

When searching for a quoted string, the words in the quoted string should not be broken up and search for separately.

The attached patch includes support for such searches as:

stuff "other things"

This will find posts that match both "stuff" and "other things".

Check stripslashes() calls, please.

​By request.

Attachments (2)

query.diff​ (2.1 KB) - added by ringmaster 7 years ago.
Mentioned patch.
search-with-quotes.diff​ (2.1 KB) - added by snakefoot 6 years ago.
Patch for branch 2.0

Download all attachments as: .zip

Change History (8)

ringmaster — 7 years ago

Mentioned patch.

comment:1   foolswisdom — 7 years ago

  • Keywords has-patch added
  • Milestone set to 2.1

comment:2   Viper007Bond — 7 years ago

Sweet. A much needed search upgrade.

comment:3   matt — 7 years ago

+1, please commit

comment:4   markjaquith — 7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4426]) Allow "quoted strings" to be used in searches. mega free-beer-when-I-finally-meet-you-in-person props to ringmaster. fixes #3177

comment:5   snakefoot — 6 years ago

  • Milestone changed from 2.1 to 2.0.eventually
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 2.1 to 2.0

Could this be applied to the 2.0 branch ? Every time a security fix comes for 2.0 then I have to re-apply this wonderful patch.

snakefoot — 6 years ago

Patch for branch 2.0

comment:6   ryan — 6 years ago

  • Milestone changed from 2.0.eventually to 2.1
  • Resolution set to fixed
  • Status changed from reopened to closed

2.0 is restricted to security fixes.

Note: See TracTickets for help on using tickets.