Opened 7 years ago

Closed 7 years ago

#3212 closed defect (bug) (fixed)

Inline Upload Style

Reported by: mdawaffe Owned by: mdawaffe
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: JS CSS upload has-patch commit
Cc:

Description

Even after [4349], some of the inline upload inputs are pretty narrow. This can be particularly frustrating when writing a long description.

Attached

  1. Widens some of the inputs and tables.
  2. Adds an easy way of grabbing the uploaded file's URL.
  3. onclick="false" on direct links to files when in inline mode so that the user never gets to a dead end in the iframe (the links are still there to be right clicked or whatever).
  4. Better defaults for the_attachment_links().
  5. Fixes nonce bug when deleting freshly uploaded file.

Attachments (9)

3212.diff​ (14.5 KB) - added by mdawaffe 7 years ago.
Picture 8.png​ (9.5 KB) - added by mdawaffe 7 years ago.
Picture 9.png​ (51.6 KB) - added by mdawaffe 7 years ago.
Picture 10.png​ (31.0 KB) - added by mdawaffe 7 years ago.
Picture 11.png​ (33.9 KB) - added by mdawaffe 7 years ago.
Picture 12.png​ (42.3 KB) - added by mdawaffe 7 years ago.
Picture 13.png​ (54.4 KB) - added by mdawaffe 7 years ago.
Picture 14.png​ (69.4 KB) - added by mdawaffe 7 years ago.
3212b.diff​ (19.0 KB) - added by mdawaffe 7 years ago.
+ some send to editor bugs

Download all attachments as: .zip

Change History (14)

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

mdawaffe — 7 years ago

comment:1   mdawaffe — 7 years ago

  • Keywords has-patch commit added
  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

mdawaffe — 7 years ago

+ some send to editor bugs

comment:2   mdawaffe — 7 years ago

3212b.diff

  1. All of the above and fixes some send to editor, relative/absolute bugs.

comment:3   ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4355]) Inline uploader styling from mdawaffe. fixes #3212

comment:4   Sewar — 7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

There's a typo in ​wp-admin/upload.css:L65:

#uupload-file th {

Should be:

#upload-file th {

comment:5   mdawaffe — 7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Actually, it shouldn't be there at all, in my opinion.

See #3194

Note: See TracTickets for help on using tickets.