Opened 7 years ago

Closed 7 years ago

#3246 closed enhancement (fixed)

make menu items in menu-headers.php relative

Reported by: bmontgom Owned by: anonymous
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: SSL dev-feedback
Cc:

Description

The URIs for the menu items in menu-headers.php are not relative URIs. These are the only URIs on the page that are not this way. I've been working on a plugin to allow for the login, register, and admin functions to be done using SSL. It is working, but I had to modify menu-headers.php to make the menu item URIs relative in order to get everything correct. A patch for my changes is attached.

Attachments (1)

menu-header.php.diff​ (1.4 KB) - added by bmontgom 7 years ago.
patch for menu-headers.php

Download all attachments as: .zip

Change History (6)

bmontgom — 7 years ago

patch for menu-headers.php

comment:1   Sewar — 7 years ago

  • Keywords SSL added

You can use ​Secure Admin which used in WordPress.Com, see: ​http://wordpress.com/blog/2006/03/08/secure-blogging/.

comment:2   foolswisdom — 7 years ago

  • Keywords dev-feedback added
  • Milestone set to 2.1
  • Version set to 2.1

ENV: WP trunk svn r4415

With my limited knowledge, I can't think of a negative to having the URLs be relative, and I see a small benefit.

Adding Milestone and putting it to dev-feedback

comment:3   markjaquith — 7 years ago

Only potential downside I can see is that it wouldn't work if there was a WP admin page in a subdirectory of /wp-admin/

Can we think of any case where that would happen? I've certainly never seen it.

comment:4   matt — 7 years ago

No opinion.

comment:5   markjaquith — 7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4443]) Make menu items linked with relative URLs. Props bmontgom. fixes #3246

Note: See TracTickets for help on using tickets.