Opened 7 years ago

Closed 7 years ago

#3340 closed defect (bug) (fixed)

File upload send to editor not valid xhtml code

Reported by: tassoman Owned by: mdawaffe
Priority: normal Milestone: 2.1
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch commit
Cc:

Description

There are single quotes (') instead of double quotes (") in the xhtml code sent to the editor by the inline file upload box.

<img src='/myimg.jpg' /> isn't valid xhtml code.

Attachments (1)

3340.diff​ (1.6 KB) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1   skeltoac — 7 years ago

  • Resolution set to invalid
  • Status changed from new to closed

tassoman: single quotes are valid for xhtml attributes. the only thing wrong with the markup you posted here is a missing attribute.

comment:2   tassoman — 7 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Ok it validates strict also with single quote, but there's too much single quotes after rel= attribute

rel='attachment wp-att-509

mdawaffe — 7 years ago

comment:3   mdawaffe — 7 years ago

  • Keywords has-patch commit added
  • Owner changed from anonymous to mdawaffe
  • Status changed from reopened to new

Patch attached. Will need to bump JS version number.

comment:4   markjaquith — 7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4461]) valid XHTML for uploader. props tassoman and mdawaffe. fixes #3340

Note: See TracTickets for help on using tickets.