wp_return() function for echo/return logic

[markjaquith]

Elegant echo/return logic wrapper by Andy Skelton

Look at all the red in the patch!

// Implementation within function:  return wp_return($func_data, $echo_flag);
function wp_return($data, $echo = true) {
	echo ( $echo ) ? $data : '';
	return $data;
}

Patch for trunk

Just though I'd point out that this isn't the same as the code as the code it replaces (this new function always returns something, even if it echo's it first).

Not saying this is bad (I personally think it's good as you can see what a function echo'ed), just pointing out the difference.

+1

Was missing a tab

Replying to markjaquith:

Elegant echo/return logic wrapper by Andy Skelton

Look at all the red in the patch!

// Implementation within function:  return wp_return($func_data, $echo_flag);
function wp_return($data, $echo = true) {
	echo ( $echo ) ? $data : '';
	return $data;
}

As Viper007Bond says, this is wrong, it will always produce and echo and then return the same value.

The function should be as follows,

function wp_return($data, $echo = true) {
	if ($echo) :
		echo $data;
	else :
		return $data;
	endif;
}

function wp_return( $what, $echo = true ) {
	if ( $echo ) {
		echo $what;
	} else {
		return $what;
	}
}

While i think this is a good idea, There doesnt seem much traction on implementing this, I'm going to set it to 2.5 for now, Feel free to move back to 2.4 if someone wants to do it.

Better code (I think this works):

function wp_return( $what, $echo = true ) {
	( $echo ) ? echo $what : return $what;
}

Is this worth implementing? If not then just close as won't fix.