Change in 'Add link' behaviour in RTE

[podz]

At one time, when you inserted a link the "​http://" was already

highlighted, so you could just paste in the link you can copied from
the address bar, overlaying the "​http://" already there. Now this
"​http://" is no longer highlighted, so you have to backspace over it
to wipe it out before or after you paste in the link.

Was this a deliberate change and will it be reverted ?

(Apologies if this is the wrong place for this)

I think you're thinking of when the RTE is off and it's just a standard JS prompt. In 2.0.5, there's nothing in the URL box. ;)

However, this should be easy to do if it's generally agreed that we want this. :)

In that case I was wrong - it's in 2.1a

+1 for highlighting it. anything that kills paste ability is bad. BUT, we could also check for double ​http:// or ​https:// on the backend like so:

$url = preg_replace('|^http(s)?://http(s)?://|', 'http$2://', $url);

I see people doing that ALL the time, so this could be once of those nice "it just works" features. Even with highlighting, people are going to get it wrong sometimes.

Note: this new behavior was introduced to RTE by ticket:2579 (dupl #3192) r4597 a week ago, but that added the '​http://', it was not previously there nor highlighted.

+1 selected

Patch for trunk, highlights ​http://

Patch uploaded. Seems to work. I'll wait for Andy's +1 on the patch before it goes in, however.

Lovely!

(In [4642]) Select http when linking. Props markjaquith. fixes #3462