Ticket #3523 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

Permalink Options page needs to 'HTML entitise' the displayed htaccess rules in the textarea element.

Reported by: JeremyVisser Owned by: anonymous
Priority: normal Milestone: 2.0.8
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch
Cc:

Description

In /wp-admin/options-permalink.php, when your .htaccess file isn't writable by the server, WordPress will display a textbox for you to copy-and-paste the permalink rules from.

The rules contain the lines "<IfModule mod_rewrite.c>" and "</IfModule>" which must be encoded with HTML entities if it is to be well-formed XHTML. Encoding with wp_specialchars() does the trick.

Attachments

options-permalink.php.diff Download (584 bytes) - added by JeremyVisser 5 years ago.
Uses wp_specialchars() around the .htaccess rules

Change History

JeremyVisser — 5 years ago

Uses wp_specialchars() around the .htaccess rules

comment:1   markjaquith — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [4681]) Ensure XHTML validity when presenting mod_rewrite rules for copy-paste. Props JeremyVisser. fixes #3523

comment:2   markjaquith — 5 years ago

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from 2.1 to 2.0.7

Revisit for 2.0.7

Note: unlike most wp_specialchars() omissions, this one does not appear to have security implications... it's just an issue of XHTML validity.

comment:3   markjaquith — 5 years ago

  • Milestone changed from 2.0.7 to 2.0.8

comment:4   markjaquith — 5 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [4789]) Ensure XHTML validity when presenting mod_rewrite rules for copy-paste. Props JeremyVisser. fixes #3523

Note: See TracTickets for help on using tickets.