WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#3590 closed defect (bug) (fixed)

l10n system should be initialized later

Reported by: nbachiyski Owned by: anonymous
Priority: low Milestone: 2.1
Component: General Version: 2.1
Severity: normal Keywords: has-patch i18n
Cc:

Description

In wp-settings.php there are i18n-ed strings, before loading the text domain. There is no problem to load it a little bit earlier.

Also - there is a string, which canno be i18n-ed, because the engine is both no loaded and could not be loaded at that time.

Attachments (2)

i18n-move-init.diff​ (2.0 KB) - added by nbachiyski 6 years ago.
i18n-unmove-init.diff​ (1.0 KB) - added by nbachiyski 6 years ago.
Almost a reverse of the older one.

Download all attachments as: .zip

Change History (8)

nbachiyski — 6 years ago

comment:1 ryan — 6 years ago

We can't call get_locale() until after plugins are loaded.

comment:2 nbachiyski — 6 years ago

Yeap, I was quite sure there was something rotten in the ease of this patch and I didn't have time to investigate - it worked at the first pass...

So then maybe we should at least remove the __() call.

comment:3 ryan — 6 years ago

Yes, remove the gettext from that string.

comment:4 foolswisdom — 6 years ago

  • Keywords needs-patch added; patch removed

nbachiyski — 6 years ago

Almost a reverse of the older one.

comment:5 nbachiyski — 6 years ago

  • Keywords has-patch added; needs-patch removed

comment:6 ryan — 6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4756]) Don't gettext before l10n bits are loaded. Props nbachiyski. fixes #3590

Note: See TracTickets for help on using tickets.