WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#3788 closed enhancement (fixed)

Upgrade to TinyMCE 2.1.0

Reported by: Nazgul Owned by: rob1n
Priority: normal Milestone: 2.2
Component: Administration Version: 2.1
Severity: normal Keywords: has-patch commit
Cc:

Attachments (6)

3788.diff (62.9 KB) - added by rob1n 6 years ago.
3788.2.diff (55.2 KB) - added by rob1n 6 years ago.
Andy's changes
Picture 1.png (10.5 KB) - added by rob1n 6 years ago.
3788.3.diff (53.9 KB) - added by rob1n 6 years ago.
My latest patch
tiny.diff (50.2 KB) - added by andy 6 years ago.
My turn.
mce.diff (52.6 KB) - added by andy 6 years ago.
This one actually looks good.

Download all attachments as: .zip

Change History (13)

comment:1 foolswisdom6 years ago

  • Owner changed from anonymous to andy
  • Type changed from defect to enhancement

comment:2 rob1n6 years ago

  • Keywords dev-feedback added; editor wysiwyg rte removed
  • Priority changed from low to normal

comment:3 rob1n6 years ago

  • Keywords tinymce dev-feedback removed
  • Owner changed from andy to rob1n

rob1n6 years ago

comment:4 rob1n6 years ago

  • Keywords has-patch commit added

comment:5 andy6 years ago

Thanks for doing that patch! Some issues in the diff that should be fixed before commit:

Changing wp-includes/js/tinymce/plugins/directionality/langs/en.js may break translations.

inlinepopups/editor_plugin.js -287,+392 undoes a WP-specific feature: "close" buttons on the left for macs.

inlinepopups/editor_plugin.js -561,+684 removes a WP focus fix. See comment in source and test.

tiny_mce.js -5186,+5223 might suck.

themes/advanced/jscripts/link.js -25,+25 should not be changed. -58,+57 looks like it'll break anchor-only links people sometimes try to add. I think these are both WP changes.

themes/advanced/link.htm should not be changed. This is WP stuff that sets focus and reverses the button order and kills enter-key submits.

themes/advanced/css/editor_popup.css removes stuff marked as WordPress customizations.

themes/advanced/image.htm changes are all WP custom, shouldn't be changed.

themes/advanced/source_editor.htm same deal.

Updating TinyMCE is probably easier if you patch from a diff between TinyMCE releases. Diffing against WP's implementation requires this kind of attention.

rob1n6 years ago

Andy's changes

rob1n6 years ago

rob1n6 years ago

My latest patch

andy6 years ago

My turn.

andy6 years ago

This one actually looks good.

comment:6 andy6 years ago

mce.diff applies the upgrade and fixes all of the interaction issues I could find. Ready for commit and broader testing.

comment:7 rob1n6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5256]) Upgrade TinyMCE to 2.1.0. Props andy. fixes #3788

Note: See TracTickets for help on using tickets.