Opened 6 years ago

Closed 6 years ago

#3834 closed defect (bug) (fixed)

wp_rss() puts item description in title attribute

Reported by: foofy Owned by: rob1n
Priority: low Milestone: 2.3
Component: General Version: 2.1.1
Severity: normal Keywords: has-patch commit
Cc:

Description

wp_rss() puts the full item description (including HTML tags) in the title. This causes validation errors, and adds a lot of bloat to the HTML that a lot of users won't see.

Attachments (2)

wp_rss_description_removal.diff​ (1.0 KB) - added by markjaquith 6 years ago.
Removes description from the title
3834.diff​ (1.4 KB) - added by rob1n 6 years ago.

Download all attachments as: .zip

Change History (14)

comment:1   foofy — 6 years ago

  • Component changed from Administration to General

comment:2   foolswisdom — 6 years ago

  • Milestone changed from 2.3 to 2.2

markjaquith — 6 years ago

Removes description from the title

comment:3   markjaquith — 6 years ago

  • Keywords has-patch added

Patch removes it for wp_rss() and get_rss()

comment:4   Otto42 — 6 years ago

The title tag appears when you hover over a link in most user agents. Do we really want to eliminate this?

comment:5   markjaquith — 6 years ago

We don't want it to be the full description. And title is redundant.

comment:6   foolswisdom — 6 years ago

  • Keywords has-patch removed
  • Milestone changed from 2.2 to 2.4

comment:7   foolswisdom — 6 years ago

  • Keywords has-patch added
  • Milestone changed from 2.4 to 2.3

comment:8   foolswisdom — 6 years ago

  • Owner changed from anonymous to markjaquith

comment:9   rob1n — 6 years ago

  • Owner changed from markjaquith to rob1n
  • Status changed from new to assigned

comment:10   rob1n — 6 years ago

We could do attribute_escape( strip_tags( $desc ) ).

rob1n — 6 years ago

comment:11   rob1n — 6 years ago

  • Keywords commit added

comment:12   rob1n — 6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5698]) wp_rss() updates. fixes #3834

Note: See TracTickets for help on using tickets.