Opened 6 years ago

Closed 6 years ago

#3958 closed task (blessed) (fixed)

New style internationalization of quicktags.js

Reported by: nbachiyski Owned by: Nazgul
Priority: normal Milestone: 2.2
Component: General Version: 2.2
Severity: normal Keywords: i18n js has-patch
Cc:

Description

quicktags.js should also be i18ned using the new system, devised by mdwaffe.

However we should think of other place for defining the translatable strings, not in script-loader.php, because there could be plenty of them. We can have a separate file for js gettext strings - script-i18n.php.

Attachments (2)

3958.diff​ (3.8 KB) - added by Nazgul 6 years ago.
3958b.diff​ (3.9 KB) - added by Nazgul 6 years ago.

Download all attachments as: .zip

Change History (10)

comment:1   nbachiyski — 6 years ago

  • Keywords i18n js added

comment:2   Sewar — 6 years ago

See also #3181

comment:3   ryan — 6 years ago

A separate file is fine.

Nazgul — 6 years ago

comment:4   Nazgul — 6 years ago

  • Keywords has-patch added
  • Milestone changed from 2.3 to 2.2
  • Owner changed from anonymous to Nazgul

comment:5   ryan — 6 years ago

s/Quick Links1/Quick Links/

I think we should attribute_escape() strings that are bound for attributes.

Otherwise, looks good.

Nazgul — 6 years ago

comment:6   Nazgul — 6 years ago

  • Status changed from new to assigned

The patch has been updated per ryan's suggestions.

I removed the 1 (wonder how it got in in the first place) and added attribute_escape() to the 4 strings that go into attributes.

comment:7   ryan — 6 years ago

We can handle moving the strings to another file with a new ticket.

comment:8   ryan — 6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5167]) i18n for quicktags.js. Props Nazgul. fixes #3958

Note: See TracTickets for help on using tickets.