Ticket #4057 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Add widgets compatibility to default and classic themes

Reported by: Otto42 Owned by: rob1n
Priority: normal Milestone: 2.2
Component: Template Version: 2.1.2
Severity: normal Keywords: has-patch commit
Cc:

Description

Widget compatibility really should be in the core code. Just my opinion, but it would save a lot of people a lot of trouble.

Even if we don't move the widgets plugin in as a default included plugin, it would be nice if the core themes were widget-friendly, in the hopes that people making themes will get the hint and make their themes widget friendly as well.

Patch included. It's not exactly the same as the mods that come with the widgets plugin, as I felt it was useful to explicitly specify the before & after bits for each theme in the functions.php files instead of hoping that the defaults for the widgets plugin don't change.

Attachments

themes-widgets.diff Download (2.2 KB) - added by Otto42 5 years ago.
Adds widget support to the default and classic themes.
4057.diff Download (479 bytes) - added by johnbillion 5 years ago.
Fix typo in wp-content/themes/classic/functions.php at r5154

Change History

Otto425 years ago

Adds widget support to the default and classic themes.

  • Keywords has-patch added
  • Keywords 2nd-opinion added

I recall discussing this with Ryan a few weeks ago and the response was that it wasn't necessary. I'm not sure if that's changed, though it might make a nice addition.

+1.

  • Keywords commit added; 2nd-opinion removed

Just talked to Matt, and it's going in. Sweet.

  • Status changed from new to closed
  • Resolution set to fixed

(In [5151]) Add widget support (if plugin is available) to default themes. Props Otto42. fixes #4057

  • Status changed from closed to reopened
  • Resolution fixed deleted

You forgot to add the new functions.php file for the classic theme, unless it's in another changeset or I'm stupid and missing something. ;-)

  • Owner changed from anonymous to rob1n
  • Status changed from reopened to new

Nah, I'm just an idiot :\.

  • Status changed from new to closed
  • Resolution set to fixed

(In [5154]) Add classic theme's functions.php. Good eyes, Otto42. fixes #4057

Fix typo in wp-content/themes/classic/functions.php at r5154

  • Status changed from closed to reopened
  • Resolution fixed deleted

Just by looking at it, I think there's a typo in /wp-content/themes/classic/functions.php at r5154 on line 2. It should be

if ( function_exists('register_sidebar') )

and not the plural register_sidebars. Patch attached.

  • Status changed from reopened to new

My bad.

  • Status changed from new to closed
  • Resolution set to fixed

(In [5176]) Fix typo. Props johnbillion. fixes #4057

Note: See TracTickets for help on using tickets.