#4059 closed defect (bug) (wontfix)
L10N Support in Default Theme
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | I18N | Version: | 2.1.2 |
| Severity: | normal | Keywords: | has-patch 2nd-opinion i18n |
| Cc: | Sewar, nbachiyski@… |
Description
See #3953 for details
Attachments (2)
Change History (16)
comment:2
nbachiyski
— 6 years ago
- Keywords i18n added
- The beginning of comments-popup has a naked printf, without __
- There are some places (for example "« %link" and "%s at %s", %1$s to “%2$s”"), where we could use the new _c function (see #3687)
- Some more changes, differenet from i18n have passed through your diff: some stylesheet modifications (Arabic fonts), for example.
- It is nice that the strings are in a different domain--the theme authors will be more and more inspired and will gain some know-how :-)
Very good work, Sewar! Let's hope Matt wouldn't mind letting this in.
comment:3
Sewar
— 6 years ago
- Cc Sewar added
I have updated the patch, fixed the bug in comments-popup.php file, removed CSS related fixes (the Arabic fonts) and will add them in new ticket.
About the new _c function, it looks its development didn't finished yet.
comment:4
abelcheung
— 6 years ago
The _c() function has already landed in subversion. Just that nbachiyski propose to put the context part behind the real translatable string, instead of the current status (before the real string).
comment:5
abelcheung
— 6 years ago
- Cc abelcheung added
comment:6
abelcheung
— 6 years ago
Couple of places that looks curious to me:
- Why some of the ‘ and ’ are replaced by ' ?
- In sidebar.php, why inserting link breaks in between middle of certain sentences but not others?
comment:7
abelcheung
— 6 years ago
I have uploaded additional stuff on top of Sewar's patch:
- Header image and color page now localizable
- Mark more strings translatable and minor fixes here and there
comment:10
abelcheung
— 6 years ago
- Cc abelcheung removed
comment:11
foolswisdom
— 6 years ago
Relates to #4817
comment:12
foolswisdom
— 6 years ago
- Cc nbachiyski@… added
comment:13
nbachiyski
— 6 years ago
- Resolution set to wontfix
- Status changed from new to closed
comment:14
Nazgul
— 6 years ago
- Milestone 2.3 deleted
I think it's a good idea. Makes sense that seeing it done in the default theme would encourage people to do it in their own themes.