tinymce language pack loading fails if no locale is defined

[m0n5t3r]

If there is no locale defined, the TinyMCE language setting is empty, which leads to incorrectly generated paths for plugin language packs. The attached patch sets it to "en", which is the TinyMCE default value.

I'm marking this as major because it affects to various degrees all TinyMCE plugins that use language packs (between localization not working and meltdown - in my case it disabled the post publishing i.e. meltdown).

You're missing an echo.

(In [5219]) Default to 'en' for TinyMCE language if get_locale() is empty, to avoid meltdowns. Props m0n5t3r. fixes #4118 for 2.1

now for 2.2

(In [5220]) Default to 'en' for TinyMCE language if get_locale() is empty, to avoid meltdowns. Props m0n5t3r. fixes #4118

This is throwing a PHP error on my local install:

Fatal error: Can't use function return value in write context in ...\wp-includes\js\tinymce\tiny_mce_config.php on line 52

I've attached a patch that should fix that problem: I think the argument passed to empty has to be a variable.

Well, that's retarded ;). Fixing.

(In [5224]) empty() only takes variables. Props filosofo. fixes #4118

(In [5225]) empty() only takes variables. Props filosofo. fixes #4118 for 2.1

Milestone 2.1.4 deleted