author pages do an uncached user_nicename lookup

[andy]

This isn't an issue until you have a large users table, but these lookups should be cached. Attaching a patch.

Shouldn't it be get_user_id_by_nicename()? Since it only returns the ID, as far as I can tell...

To me, get_user_by_nicename() returns an user object with that nicename.

Sure, whatever you want to call it.

Looks ok.
I agree with rob1n that the function name should be changed. Furthermore IMHO the cache name should also reflect that user ids are cached, not nicenames. I'd call it user_id_by_nicename or sth. like that.

Nice chunky patch that could do with some love as it no longer applies.

Pushing to 2.6 with needs-patch but will possibly accept for 2.5 if patch is updated.

new patch does the following, against 2.8/trunk:

• add a get_user_by_nicename() function that caches its results
• sets and flushes the cache where appropriate
• uses the function in WP_Query

See also: #1626, #9563 and #9564

Should we pattern after get_term_by() and have one function -- get_user_by() -- for handling retrieving by various fields? Also, I prefer the term "slug" to "nicename". I think it makes it clearer what the field is. So, get_user_by('slug', 'admin');

(In [10992]) Cache user lookups made by nicename. Add get_user_by(). fixes #4170