upload.php page navigation goes to users.php?paged=xxx

[devil1591]

The page navigation in upload.php links to users.php?paged=xxx

This must have been fixed since your post for this, and me SVN CO the 2.2 branch? Because at Manage > Upload link it's working. I'm not seeing that issue you're having?

​http://2.2.spencerp.net/wp-admin/upload.php = Works fine for me, am I missing something maybe? I could be, I'm riding on -X hours of sleep here again. lol

Also, any links while after I uploaded an image and then browsed the uploaded image, works too. Nothing was breaking or sending me else where...

"links" = ​http://2.2.spencerp.net/wp-admin/upload.php?action=view&ID=4 = Worked!
"view" = ​http://2.2.spencerp.net/?attachment_id=4 = Worked!
"browse all" = ​http://2.2.spencerp.net/wp-admin/upload.php?action&ID=&tab=browse-all&paged = Worked!

I confirm the bug, tested on a fresh svn 5290, in wp-admin/upload.php line 107, the bug is

'base' => 'users.php?%_%',

when you browse files, you get back to users.php

Confirmed, patch attached.

Ok my patch completely fails to fix anything at all. Excuse me while I go and get some sleep.

this patch actually works, based on tests from duplicate ticket #4187

(In [5295]) Fix variable collission in _get_cat_children. see #3985

(In [5296]) Fix variable collission in _get_cat_children. For 2.2. see #3985

It's only "fixed" when it's in the SVN :).

As I said, this patch doesn't work. The changes made to upload.php in r5226 need to be reverted, as the changes in that revision were accidentally applied to upload.php instead of users.php unless I'm mistaken.

johnbillion, the problem is in wp-admin/upload.php, when you navigate in uploads, the second page links to users.php?paged=xxx.

users.php does not have any problem.

Am I right in thinking r5322 fixes this? I'm not in a position to test at the moment.

Same fix is needed in 2.2, it looks like (r5324)

Replying to foolswisdom:

Same fix is needed in 2.2, it looks like (r5324)

Oops, I should have said I was at r5324, I know see that it reads like r5324 was the fix.

Both 2.2 and 2.3 currently have the same code. If it works in trunk, 99% sure it works in 2.2.

Yeah, looks like it was fixed in r5369.