Ticket #4243 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

Properly handle uploaded files for blogroll imports

Reported by: apokalyptik Owned by: anonymous
Priority: normal Milestone: 2.3
Component: Administration Version:
Severity: normal Keywords:
Cc:

Description

Fix 1 since wp_remote_fopen does not properly handle local files versus remote urls (and by the name of the function probably should not do so anyhow ("remote" and all that) Uploading a file instead of linking to a file already on the web for import caused $opml to be set as boolean false. This in turn was not very parse-able by the xml routines. So I wrapped the setting of $opml in an if statement that would use file_get_contents() for local files and wp_remote_fopen() for remote files.


Fix 2 unlinking an uploaded file for import should pass the file through the wp_delete_file filter.

Attachments

changeset_trunk_wp-admin_link-import.php.diff Download (644 bytes) - added by apokalyptik 5 years ago.

Change History

comment:1   ryan5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5438]) Handle local and remote blogroll imports. Props apokalyptik. fixes #4243 for 2.2

comment:2   ryan5 years ago

(In [5439]) Handle local and remote blogroll imports. Props apokalyptik. fixes #4243 for 2.3

  • Milestone changed from 2.4 to 2.3
Note: See TracTickets for help on using tickets.