Text & page widget improvemets

[Denis-de-Bernardy]

XP SP2, IE7

The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.

In addition, please be so kind to apply the attached patch. It does the following:

1. add an option to wpautop text widgets
2. add an option to exclude pages from the pages widget
3. sort page widgets using menu_order rather than by their title

If your patch doesn't fix the IE7 issue, you should create a new ticket for it, and explain the reasoning behind it.

So your patch doesn't fix errors in IE 7? ...

Open another ticket for the IE 7 bug.

Also, we should wp_texturize() the text widget's contents.

wp_list_pages() should sort by menu_order,post_title by default. As for the options, I'd rather wait until 2.2.x. We're planning to add a bunch of options to the widgets.

(In [5486]) Texturize and autop the text widgets, and allow pages to be sorted by a specified field. Props Denis de Bernardy. see #4259

page order + text widget filters

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

D.

lastly, in the text widget's title, if the title is empty, it is turned into a non-breaking space. this defeats the purpose of:

<?php !empty( $title ) ? print($before_title . $title . $after_title) : null; ?>

D.

Replying to Denis-de-Bernardy:

if you apply the filter 'the_content', you'll get plenty bugs with plugins along the lines of podpress. e.g. if the last post in the loop has media attached to it, each text widget will have a few media links.

Makes sense. I guess we can make the text widget its own filter.

also, the page exclude is heavily requested (at least among the users I'm babysitting).

Next thing I'm looking at :).

autop and texturize are breaking the Google Reader Clip snippet. script tags are peed on and the script src is texturized. Since text widgets are commonly used for such snippets, we need to make sure we don't break them.

Which brings me back to my original proposal for making texturize/autop a checkbox :).

Ideally, it should just work.

(In [5509]) Don't show title if user leaves it blank. see #4259

(In [5517]) Remove the_content filter from widget text. see #4259

(In [5518]) Remove the_content filter from widget text. see #4259

Some plugins append things to the_content making it unsuitable for widget use. We can add a widget_text or generic text_content filter. I'd like to get autop and texturize playing nicely first.

(In [5519]) Run it through the filter. see #4259

option to exclude pages

(In [5605]) Add option to exclude pages to pages widget. see #4259

Okay, all that's left is autop and texturize.

Replying to Denis-de-Bernardy:

The errors that the attached screenshot will highlight have been around on wordpress.com for longer than I can remember. I'm surprised noone has ever bothered to file them.

*chuckle* We have. :)

Replying to rob1n:

Okay, all that's left is autop and texturize.

Maybe, open a new ticket and close this one b/c it is in a released version?

Closing as fixed.