Ticket #4267 (closed defect (bug): worksforme)
wp_list_pages using a 'the_title' on all entries
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.8 |
| Component: | Template | Version: | 2.2 |
| Severity: | normal | Keywords: | reporter-feedback |
| Cc: | david@… |
Description
I have a plugin that – when a specific ‘page’ is displayed (checked by is_page and ID) a filter changes the page title using a standard add_filter on ‘the_title’. If wp_list_pages() is being used on the sidebar, ALL page titles are getting altered in the list output. I have just checked and this does not seem to be the case using 2.1.3 As an aside, optionally passing the post ID into 'the-title' would be useful.
Change History
- Keywords 2nd-opinion added
- Owner ryan deleted
- Milestone changed from 2.2.1 to 2.4
I'm of the opinion that this is at the fault of the plugin.
- Milestone changed from 2.4 to 2.2.1
This is a sideeffect of the changes made to wp_list_pages to try and support what is wanted in #4004.
It shows why reusing filters all over the code for similar but not identical things in not a good idea!
filter names should relate to where there are called from not the item of data on which the operate.
- Summary changed from wp_list_pages using a 'the_title' on all entries to wp_list_pages using a 'the_title' on all entries my-2cents
+1 - move the filter out of wp_list_pages. good spoken westi, strong point!
comment:10
mattyrob — 4 years ago
+1 more for moving the filter out of wp_list_pages or for providing a more elegant solution overall :-)
+1 over here as well -- the_title (or the_content, or...) are for use within the loop.
a widget_title filter would make a lot more sense.
- Status changed from new to closed
- Resolution set to worksforme
seems invalid in wp 2.8
comment:14
hakre — 3 years ago
- Keywords reporter-feedback added; wp_list_pages, filter 2nd-opinion removed
- Component changed from Administration to Template
- Summary changed from wp_list_pages using a 'the_title' on all entries my-2cents to wp_list_pages using a 'the_title' on all entries
have not tested wether this is still the case with 2.8
no direct invoke of the filter 'the_title' in function wp_list_pages() in post-template.php.
it would be good to have a test-plugin. does anybody has an idea which plugin the original reporter has used?
additionally i do not know wether the filter 'the_title' is even correct in there or not. until no more feedback provided i suggest to leave this closed.
corrected the wrong title /meshame.
