Opened 6 years ago
Closed 6 years ago
#4277 closed defect (bug) (fixed)
bug in addArg() in wp-ajax.js causes nothing to happen
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.2.1 |
| Component: | Administration | Version: | 2.2 |
| Severity: | normal | Keywords: | |
| Cc: | mdawaffe |
Description
There is a bug in the addArg() in wp-includes/wp-ajax.js
on line 30, the variable a is basically incorrectly typed:
var a = [];
it should be instead:
var a = $H();
the function definition should be:
addArg: function(key, value) {
var a = $H();
a[encodeURIComponent(key)] = encodeURIComponent(value);
this.options.parameters = $H(this.options.parameters).merge(a);
}
Attachments (1)
Change History (8)
comment:1
technosailor
— 6 years ago
comment:3
joetan
— 6 years ago
thanks technosailor.
To help clarify, the function should basically add a new key into the this.options.parameters hash variable, but it never gets updated with the new key because "a" was created as []
I'm encountering this bug with a plugin I'm working on, which does some ajax stuff. It doesn't appear that this function is actually used anywhere else within the WordPress codebase.
comment:5
rob1n
— 6 years ago
I think that should be a = $H() (note parenthesis, not square brackets).
No idea what the problem is you're encountering, however I've attached the diff of your changes for the sake of ease for the devs.