bug in addArg() in wp-ajax.js causes nothing to happen

[joetan]

There is a bug in the addArg() in wp-includes/wp-ajax.js

on line 30, the variable a is basically incorrectly typed: var a = [];

it should be instead: var a = $H();

the function definition should be:

addArg: function(key, value) {
var a = $H();
a[encodeURIComponent(key)] = encodeURIComponent(value);
this.options.parameters = $H(this.options.parameters).merge(a);
}

No idea what the problem is you're encountering, however I've attached the diff of your changes for the sake of ease for the devs.

thanks technosailor.

To help clarify, the function should basically add a new key into the this.options.parameters hash variable, but it never gets updated with the new key because "a" was created as []

I'm encountering this bug with a plugin I'm working on, which does some ajax stuff. It doesn't appear that this function is actually used anywhere else within the WordPress codebase.

I think that should be a = $H() (note parenthesis, not square brackets).

Patch updated.

Michael: look good?

(In [5498]) Fix wp-ajax.js addArg's hashes. Props technosailor. fixes #4277