Ticket #4302 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

HTML in text widgets reloaded incorectly in sidebar admin

Reported by: LiamJ Owned by: rob1n
Priority: normal Milestone: 2.2.1
Component: Administration Version: 2.2
Severity: normal Keywords: text widget xhtml compliance has-patch commit
Cc:

Description

When I visit the sidebar widget admin page and my text widget contents is reloaded from the database all the &s I had in the link text within it are retrieved as normal &s (and I assume the same applies for other tags like this?).

For example, if I'd originally entered part of my text as this;

<a href="http://www.example.com/?prop1=something&amp;prop2=somethingelse">

The sidebar admin page would be reloading it from the database like this;

<a href="http://www.example.com/?prop1=something&prop2=somethingelse">

Thus, unless I re-correct the text widget each time I go in there I end up saving a non-XHTML compliant contents to the text widget. Oh, and this is happening on load, not save. If I save after correcting the contents my generated pages are XHTML compliant.

Attachments

format_to_edit.diff Download (741 bytes) - added by ryan 5 years ago.
Pass widget text through format to edit

Change History

ryan5 years ago

Pass widget text through format to edit

comment:1   ryan5 years ago

The text wasn't being formatted for editing. Try that patch.

comment:2   ryan5 years ago

  • Milestone set to 2.2.1
  • Keywords has-patch added
  • Keywords commit added
  • Owner changed from anonymous to rob1n

I reproduced it, and then applied the patch, which worked.

  • Status changed from new to closed
  • Resolution set to fixed

(In [5499]) Pass text widget text through format_to_edit. Props Ryan. fixes #4302

Note: See TracTickets for help on using tickets.