gzhandler warning

[F3rn4nd0]

Sometimes I can see a warning in the upper side like this: Warning: ob_start(): output handler 'ob_gzhandler' cannot be used after 'URL-Rewriter related to file functions.php

I found a patch using:

  if ( extension_loaded('zlib') )
      {
         ob_end_clean();
         ob_start('ob_gzhandler');
      }
   }

instead of

      if ( extension_loaded('zlib') )
      {
         ob_start('ob_gzhandler');
      }
   }

It seems to work

Makes sense. Possibly another output buffer had started.

It is possible to check as to whether another output buffer had started?

Oh, ob_end_clean() probably shouldn't be used if another buffer had started. Unless you wish to discard the contents.

Patch based off of r6563

Needs testing (unit testing) on whether or not an notice is thrown if there is no output buffer active when ob_clean_flush() is called.

E_NOTICE has to be on in order to see if there is a notice.

Can this go in?

Let's just get rid of gzip_compression(). It's caused too many problems for such a small bit of code.

Yeah... plus, this is something that is much better if activated by a server admin at the PHP or HTTP server level. +1 for axing it. One less option!

(In [6775]) Remove gzip_compression(). Leave it to the server. fixes #4342