Opened 6 years ago

Last modified 6 weeks ago

#4463 new defect (bug)

Strange paging links

Reported by: markjaquith Owned by: ryan
Priority: normal Milestone: 3.6
Component: Permalinks Version: 2.3
Severity: normal Keywords: has-patch
Cc: saiyedfaishal@…

Description

Ryan:

In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems.

[5454] was the commit for #3930

If at all possible, I'd like to work with the new code.

Attachments (2)

4463.diff​ (956 bytes) - added by wonderboymusic 4 months ago.
4463_1.diff​ (1.1 KB) - added by faishal 6 weeks ago.
New patch

Download all attachments as: .zip

Change History (15)

comment:1   Nazgul — 6 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.3 (trunk) to 2.4 (future)

comment:2   MtDewVirus — 5 years ago

Tested with 7236.

Whenever performing searches, the search results do have URLs in the form of /?s=test.

comment:3   DD32 — 4 years ago

  • Component changed from General to Template
  • Priority changed from high to normal

What would be a suggested fix for this ticket? /search/search-term/page/2 ? /?s=search-term&paged=2 ?

comment:4   Denis-de-Bernardy — 4 years ago

+1 for this: /?s=search-term&paged=2

comment:5   Denis-de-Bernardy — 4 years ago

  • Component changed from Template to Permalinks
  • Owner changed from anonymous to ryan

comment:6   hakre — 4 years ago

/search/search-term/page/2 with a configureable option in backend for wording of "search" would be pretty nice to fillup serps.

anyway isn't this pretty uninteresting anyway as long as it doesn't lead to a 404?

comment:7   janeforshort — 3 years ago

  • Milestone changed from 2.9 to Future Release

No patch, punting.

comment:8   wonderboymusic — 8 months ago

  • Keywords reporter-feedback added; needs-patch removed

Is this still relevant?

comment:9   SergeyBiryukov — 8 months ago

  • Keywords needs-patch added; reporter-feedback removed

Paged search links still look as described: http://trunk.wordpress/page/2/?s=test.

Before [5454], they used to be http://trunk.wordpress/?s=test&paged=2.

comment:10   wonderboymusic — 7 months ago

  • Keywords has-patch added; needs-patch removed

Makes search links with pretty permalinks on used paged in the query string

wonderboymusic — 4 months ago

comment:11   wonderboymusic — 4 months ago

  • Milestone changed from Future Release to 3.6

Refreshed patch against trunk - this ticket is like 19,000 tickets old, but the patch works

comment:12   wonderboymusic — 4 months ago

#21748 was marked as a duplicate.

faishal — 6 weeks ago

New patch

comment:13   faishal — 6 weeks ago

  • Cc saiyedfaishal@… added
Note: See TracTickets for help on using tickets.