Ticket #4465 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

add_query_arg() uses REQUEST_URI when it is undesirable to do so

Reported by: markjaquith Owned by: anonymous
Priority: normal Milestone: 2.2.1
Component: General Version: 2.2
Severity: normal Keywords:
Cc:

Description

mod_rewrite permalinks, blog URL as domain root.

from  http://example.com/page/2/

code: 

echo remove_query_arg('arbitrary', '');

expected result is a blank string (remove a query arg from a blank string, you should get that same blank string back).

actual result: 

/page/2/

It's using the REQUEST URI because it thinks you haven't provided your own query string. But you have... it's just blank. add_query_arg() and remove_query_arg() need to use something other than a blank string to designate that the user has neglected to provide their own QS.

Change History

comment:1   markjaquith — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5705]) use FALSE to designate lack of user-supplied URL in *_query_arg() funcs. fixes #4465 for 2.3 (trunk)

comment:2   markjaquith — 5 years ago

(In [5706]) use FALSE to designate lack of user-supplied URL in *_query_arg() funcs. fixes #4465 for 2.2.x

Note: See TracTickets for help on using tickets.