Opened 6 years ago

Last modified 21 months ago

#4518 assigned enhancement

Nested <ol> <ul> lists display incorrectly with default theme

Reported by: andrewjorgensen Owned by: iandstewart
Priority: normal Milestone: WordPress.org
Component: Themes Version: 2.2.1
Severity: normal Keywords:
Cc: dragos.nicholas@…

Description

A nested ordered / unordered list places bullets AND numbers on the unordered list. You can see an example of this on my own site. The bug is somewhere in wp-content/themes/default/style.css. I fixed it once before but I don't recall where the bug is now.

Attachments (2)

4518.diff (394 bytes) - added by rob1n 6 years ago.
4518b.diff (377 bytes) - added by Nazgul 6 years ago.

Download all attachments as: .zip

Change History (24)

  • Milestone set to 2.2.2
  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned

rob1n6 years ago

Does that help?

  • Keywords has patch added
  • Keywords has-patch added; has patch removed

That patch would get rid of the >> marks, but not the numbering.

The bug is in the default theme's style.css:

ol li, #sidebar ul ol li {
        list-style: decimal outside;
       }

That leading "ol li" seems like it should be "#sidebar ol li" instead. Making that change will get rid of the numbers being incorrectly added to the unordered lists (which do fit that rule, given that they are "ol li ul li" and there's no overriding list-style-type for ul li's given).

Nazgul6 years ago

New patch attached, based on Otto42's suggestion.

  • Milestone changed from 2.2.2 to 2.2.3
  • Keywords commit added
  • Milestone changed from 2.2.3 to 2.3 (trunk)

This still does not solve the problem. I was also having it. It seems this is what's specifically causing the problem:

.entry ul li:before, #sidebar ul ul li:before {
	content: "\00BB \0020";
	}

This can be added to fix the glitch:

.entry ol li:before {
	content: "";
	}

However, now ol's look kind of funny. On my site I also added another line to .entry ol to make the ol's look right:

	list-style: decimal inside;

er whoops, better idea. instead of adding the list-style to .entry ol add this:

	text-indent: 0px;

Just wondering what the status of this one is...?

  • Owner rob1n deleted
  • Status changed from assigned to new
  • Keywords needs-testing added; commit removed

I really feel like the following should be added to 4518.diff:

.entry ol {
	text-indent: 0px;
	}

The code in 4518.diff + that snippet and it would be perfectly fixed. Please note that 4518b.diff does NOT fix this issue.

comment:15 follow-up: ↓ 16   mrmist4 years ago

See also #4449

comment:16 in reply to: ↑ 15   Nicholas914 years ago

  • Cc dragos.nicholas@… added

Replying to mrmist:

See also #4449

It seems that the problems are in IE7, better also check the solutions in #4449.

  • Keywords needs-patch added; has-patch needs-testing removed
  • Milestone changed from 2.9 to Future Release
  • Type changed from defect (bug) to enhancement
  • Keywords needs-patch removed
  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

n/a now we have Twenty Ten

  • Component changed from Template to Themes
  • Milestone set to WordPress.org site
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Owner set to iandstewart
  • Status changed from reopened to assigned

comment:21 follow-up: ↓ 22   GaryJ21 months ago

Is this ticket still valid now that Twenty Eleven is the default theme, and Default isn't included any more?

comment:22 in reply to: ↑ 21   johnbillion21 months ago

Replying to GaryJ:

Is this ticket still valid now that Twenty Eleven is the default theme, and Default isn't included any more?

The theme is still available on wordpress.org, which is why Nacin re-opened it after I closed it. Doesn't look like there's a lot of interest in fixing it though.

Note: See TracTickets for help on using tickets.